valyala/fasthttp

Chunked response with trailer result in "cannot find crlf at the end of chunk" error

Open

#1,078 创建于 2021年8月21日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)Go (21,741 star) (1,755 fork)batch import
help wanted

描述

Hello,

While using fasthttp.Client to talk to a server that produce chunked response with trailer headers I see "cannot find crlf at the end of chunk" error. I suspects that this happens because fasthttp's implementation does not expect to see trailer headers after the last chunk, which is not according to chunked transfer coding spec.

This can ideally be fixed by adding https://github.com/valyala/fasthttp/issues/210. Otherwise readBodyChunked need to be mindful of trailers.

Let me know if I should produce an example.

Regards.

贡献者指南

技术栈
go
领域
api
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
HTTP chunked transfer encodingGo language basicsfasthttp library structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the chunked transfer encoding RFC and the `readBodyChunked` function in `http.go` or similar file. Investigate how trailers are currently handled and whether the fix from issue #210 (trailer support) can be integrated. Consider adding logic to parse trailer headers after the terminating chunk.