valkey-io/valkey

[BUG] A large negative number(e.g. -LONG_MAX) in HRANDFIELD/ZRANDMEMBER can easily cause Valkey to crash.

开放

#844 创建于 2024年7月30日

 (18 条评论) (1 个反应) (1 位负责人)C (1,138 个派生)batch import
good first issuehelp wanted

仓库指标

星标
 (25,779 个星标)
PR 合并指标
 (平均合并 17天 7小时) (30 天内合并 74 个 PR)

描述

Describe the bug

When using the HRANDFIELD or ZRANDMEMBER commands, if an extremely negative value(e.g. -LONG_MAX) is provided, the memory will continue to rise and eventually cause Redis to crash.

To reproduce

HRANDFIELD hash -9223372036854775807

Expected behavior

IMHO, it is more reasonable to set a limit on count according to the memory limit or the actual size of the hash table to prevent Redis from crashing. This can prevent crashes caused by careless and incorrect use. If a user really needs to sample a lot of elements that allow duplicates, he can achieve the same purpose by calling the command multiple times.

贡献者指南