validatorjs/validator.js

Missing validation for Macedonian phone numbers

Open

#2,497 创建于 2024年11月14日

在 GitHub 查看
 (11 评论) (0 反应) (1 负责人)JavaScript (22,497 star) (2,253 fork)batch import
good first issuepr-raised🐛 bug

描述

Explanation validator.isMobilePhone cannot validate a good (valid) Macedonian phone number.

The macedonian number starts with +389, and is followed by 8 digits, or if written with national prefix (0), it will be 9 digits in length.

Additional context Validator.js version: v.13.11.0 Node.js version: v23.1.0

贡献者指南

技术栈
javascriptnodejs
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptregex
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requests adding support for Macedonian phone numbers to the `isMobilePhone` validator. The codebase has a locale map in `src/lib/isMobilePhone.js`. You need to add a new locale key 'any' or 'mk' with a regex pattern covering +389 followed by 8 digits or 0 followed by 9 digits, and possibly variations with spaces or dashes. Check existing locales for patterns, and add corresponding tests in `test/validators.js`. Since the issue is assigned, coordinate with the assignee or maintainers before proceeding.