vaadin/framework

Deprecate MultiSelectionEvent.getNewSelection

开放

#11,756 创建于 2019年10月23日

 (1 条评论) (1 个反应) (0 位负责人)Java (715 个派生)auto 404
Help wantedStale

仓库指标

星标
 (1,806 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Description copied from https://github.com/vaadin/flow/issues/6756

The class has three methods for the same thing:

Set<T> getValue()
Set<T> getAllSelectedItems()
Set<T> getNewSelection()

The first two are inherited, but getNewSelection exists only in MultiSelectionEvent.

Another reason to deprecate it is that the naming can cause confusion. We got feedback that a user expected the method to return the newly added items (compared to the old selection), i.e. what getAddedSelection returns.

JavaDocs should suggest to use getAllSelectedItems or getValue instead.

贡献者指南