umputun/remark42

Separate vendor from widgets bundles

Open

#901 创建于 2021年2月25日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Go (5,500 star) (432 fork)user submission
enhancementfrontendgood-first-issuehelp wanted

描述

It's a really good thing in the case when remark42 installed on a page with the two widgets comments and last comments. Both of the widgets have bundles that include preact, redux, etc. It could be much more effective to separate vendor bundle and use the same piece of code for these widgets.

贡献者指南

技术栈
javascripttypescriptgo
领域
frontendperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
familiarity with Go build systemunderstanding of JavaScript bundling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the current build process in the repository, likely involving Webpack or a similar bundler for the frontend widgets. Identify the common vendor dependencies (e.g., preact, redux) shared between 'comments' and 'last comments' widgets. Then propose splitting the vendor code into a separate bundle that can be cached and reused. Look for existing build configurations in the repository, such as webpack.config.js or Makefile, and study how bundles are currently generated. The implementation should ensure backward compatibility and maintain the existing widget APIs.