uber/react-vis

Thoughts on viewBox property

Open

#901 创建于 2018年8月16日

在 GitHub 查看
 (8 评论) (1 反应) (0 负责人)JavaScript (8,615 star) (868 fork)batch import
enhancementhelp wanted

描述

I've been experimenting with react-vis components library and modifying it to pass a viewBox property all the way down to the svg element in XYPlot.

The results so far have been quite promising:

  • The elements inside the graph can easily be deployed in relation to each other using the internal coordinate system
  • Sizes can also be expresses in a way consistent with that system
  • The SVG scales appropriately, and it can be combined easily with flexbox.

So my question is: why is it that this doesn't have support out of the box? Is there any drawbacks I'm not noticing.

Thanks.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Knowledge of ReactUnderstanding of SVG viewBox
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Review the XYPlot component in react vis to understand how SVG attributes are currently passed. Examine the viewBox property specification and how it could be integrated. Look for any prior discussion or PR references in the comments. The issue asks for support out of the box, so research the existing prop passing mechanism and propose a minimal implementation.