uber/react-vis

LineSeriesCanvas in FlexibleXYPlot container renders in incorrect size on retina screens

Open

#1,063 创建于 2018年12月12日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (8,615 star) (868 fork)batch import
bughelp wanted

描述

Example: https://codepen.io/marton/pen/aPvody

This can be reproduced by putting any canvas series in a FlexibleXYPlot container as long as devicePixelRatio !== 1.

#605 seems related

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of Reactunderstanding of canvas renderingfamiliarity with devicePixelRatio
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue can be reproduced using the provided CodePen example (https://codepen.io/marton/pen/aPvody) where a LineSeriesCanvas inside a FlexibleXYPlot shows incorrect sizing on retina screens (devicePixelRatio !== 1). The related issue #605 (https://github.com/uber/react vis/issues/605) likely provides additional context. To fix, investigate the FlexibleXYPlot and LineSeriesCanvas components in the react vis source code, specifically how they handle device pixel ratio and container dimensions. The fix may involve adjusting the canvas size or scaling context based on devicePixelRatio.