uber/piranha

PiranhaObjC: Use properties.json to specify configuration properties

Open

#51 创建于 2020年6月15日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Java (2,143 star) (178 fork)batch import
enhancementgood first issuehelp wantedlegacy-objc

描述

Currently PiranhaObjC APIs are hardcoded. See here. Introduce a configuration json file that contains an array of methodProperties with methodName, flagType, returnType and argumentIndex. See below.

{ "methodProperties": [ { "methodName": "isToggleEnabled", "flagType": "treated", "returnType": "boolean", "argumentIndex": 0 }, ... ], }

This properties file will be parsed and the listed APIs will be used for refactoring.

贡献者指南

技术栈
cppobjective c
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic knowledge of C++Understanding of JSON
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Review the current hardcoded API definitions in https://github.com/uber/piranha/blob/master/objc/src/XPFlagRefactoring/XPFlagRefactoring.cpp#L40. Investigate how to parse a JSON file (properties.json) containing an array of methodProperties objects with fields methodName, flagType, returnType, and argumentIndex. Look into existing JSON parsing libraries in the project or consider using a lightweight C++ JSON parser. After parsing, replace the hardcoded calls with the dynamically loaded properties. The issue has one comment but no recent maintainer activity; it may benefit from clarifying the expected JSON structure and integration points.
PiranhaObjC: Use properties.json to specify configuration properties · uber/piranha#51 | Good First Issue