uber/piranha

PiranhaJava - Doesn't add required space while removing parentheses

Open

#37 创建于 2020年5月14日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)Java (2,143 star) (178 fork)batch import
good first issuelegacy-java

描述

Piranha changed return(true); to returntrue;. This is sort of related to #35 - in the sense that PiranhaJava doesn't validate the parens/spaces of the output generated.

This error probably would not have occured if the code had been Google Java formatted.

However, I thought I will bring it to your attention, since this is a case of Piranha introducing a "bug" instead of erring on the side of caution, like #35

贡献者指南

技术栈
java
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Javastring manipulation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Investigate the code responsible for removing parentheses in flag conditions, particularly where the return statement's space is omitted. Look at the logic that generates the output string after transformation. Review issue #35 for related validation discussions. The fix likely involves ensuring a space is inserted between 'return' and the opening parenthesis when the parenthesis is removed.