typelevel/spire

Searching API needs better documentation

Open

#786 创建于 2019年4月3日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Scala (238 fork)batch import
good first issue

仓库指标

Star
 (1,775 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

We state

  /** Performs a binary search, returns an index using the same convention as java.util.Arrays.binarySearch. */
final def search[@sp A: Order](as: Array[A], item: A, lower: Int, upper: Int): Int = {

However, our convention is to search the interval [lower, upper] inclusive, whereas java.util.Arrays.binarySearch excludes the upper bound.

贡献者指南