ExceptionSourceFilter does not properly attribute CancelledRequestExceptions · twitter/finagle#760

(1 评论) (0 反应) (0 负责人)Scala (8,864 star) (1,435 fork)batch import

help wanted

描述

ExceptionSourceFilter does not properly attribute CancelledRequestExceptions

Expected behavior

The source should be attributed to the client (or at least not to the downstream service)

Actual behavior

When a future is cancelled by a client, the source is still attributed to the downstream service. This leads to confusion when the error message is along the lines of:

com.twitter.finagle.CancelledRequestException: request cancelled. Remote Info: Upstream Address: Not Available, Upstream id: Not Available, Downstream Address: my.downstream.host/X.X.X.X:443, Downstream label: my.downstream.host:443, Trace Id: efdec7e41b7c30fa.d535d24f770f3fa8<:efdec7e41b7c30fa

even though the downstream was not involved in the request at all.

Steps to reproduce the behavior

Cancel a future and observe the attribution from ExceptionSourceFilter.

贡献者指南

技术栈: scala
领域: backend
议题类型: bug
难度: 3
预计时间: 1-2 days
活动状态: stale
清晰度: clear
前置要求: Scala basicsFamiliarity with Finagle
新手友好度: 45
研究方向: Investigate the ExceptionSourceFilter implementation in the Finagle codebase to understand how it attributes exceptions to sources. Specifically, examine how CancelledRequestExceptions are handled during client cancellation. Look at the flow where a future is cancelled by a client and trace the exception attribution logic. Check the existing comment on the issue for additional context. Consider modifying the filter to correctly attribute the source to the client or set it to 'Not Available' when cancellation occurs.