twitter/finagle

How to set Host header with LoadBalancing

Open

#562 创建于 2016年10月18日

在 GitHub 查看
 (15 评论) (0 反应) (0 负责人)Scala (8,864 star) (1,435 fork)batch import
good first issue

描述

According to #560 you may be discussing but I got confused when using Finagle's load balancing feature. In order to distribute requests to multiple servers, we instantiate a service via Http.Client#newService as follows,

val client = Http.client.newService("hostA.org:80, hostB.org:80")

Then construct request,

val request = Request("/path/to/service")
request.host = ???

client(request)

What should we fill ??? with?

Moreover, we're forced to pass the host addresses twice when the service creation and the building request. It's not DRY.

Are there any reasons that the Host header automatically set that given to the Service?

贡献者指南

技术栈
无
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ScalaFinagle basicsLoad balancing concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine the discussion in linked issue #560 and the source code for Http.Client.newService in the Finagle repository to understand how the Host header is currently handled and whether there is existing support or plans to set it automatically when load balancing. Review the 15 comments for any proposed solutions or maintainer feedback.