twitter/finagle

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6

Open

#526 创建于 2016年7月13日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)Scala (8,864 star) (1,435 fork)batch import
good first issue

描述

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

It looks like the most pivotal change is updating com.twitter.finagle.zipkin.core.Endpoint.ipv6

cc @sveinnfannar

贡献者指南

技术栈
scala
领域
backendobservability
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Scala knowledgeFamiliarity with ThriftUnderstanding of Zipkin endpoint
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is to add IPv6 support to the Endpoint class in Finagle's Zipkin integration. The key change is in the com.twitter.finagle.zipkin.core.Endpoint class, which currently only supports IPv4. The Zipkin API specification (https://github.com/openzipkin/zipkin api/blob/master/thrift/zipkinCore.thrift#L276) shows that endpoints can now optionally include an ipv6 field as a 16 byte address. To implement this, you'll need to modify the Endpoint Scala class to add an ipv6 field, update its serialization/deserialization to handle the new field, and ensure backwards compatibility with IPv4 only endpoints. The issue also mentions a contributor (@sveinnfannar) who may have further context. Review the existing codebase to understand the current Endpoint implementation and the Thrift binding, then add the ipv6 support accordingly.