twbs/icons

Font hash is hardcoded for Sass

Open

#1,926 创建于 2024年1月12日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (6,955 star) (1,049 fork)batch import
bugbuildhelp wanted

描述

This broke in #1374 /CC @GeoSot @mdo.

We could probably get the hash by splitting the string but we'll need a custom Sass function since we still support node-sass (Hugo etc).

Alternatively, we could implement a hash template variable in our https://github.com/twbs/fantasticon fork.

Also, we still have some issues like #1381.

贡献者指南

技术栈
javascriptcss
领域
frontendbuild system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Sass knowledgeNode.js basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the changes in #1374 that broke the font hash. Look at the fantasticon fork for implementing a hash template variable. Consider writing a custom Sass function as an alternative. Review issue #1381 for related context.
Font hash is hardcoded for Sass · twbs/icons#1926 | Good First Issue