tursodatabase/libsql

Total changes is accumulated per Hrana stream, not connection which is wrong

Open

#1,512 创建于 2024年6月27日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C (16,744 star) (490 fork)batch import
buggood first issuehelp wantedremote protocol

描述

We currently implement total_changes() incorrectly for Hrana client-side protocol because we accumulate the changes per stream, but should do it per connection. I merged the incorrect solution as an intermediate step to expose the API to users because fixing this is a bit involved. Hrana does pass connection to stream but turns it into something useless because of the generics trickery there.

贡献者指南

技术栈
c
领域
database
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Hrana protocolRust genericslibSQL internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Review the current implementation of total changes() in Hrana client side protocol. Examine how the stream accumulates changes and understand why the connection parameter is not used due to generics trickery. Look for existing comments or linked PRs for context, then propose a fix to move accumulation to connection level.