tursodatabase/libsql

Total changes is accumulated per Hrana stream, not connection which is wrong

开放

#1,512 创建于 2024年6月27日

 (0 条评论) (0 个反应) (0 位负责人)C (490 个派生)batch import
buggood first issuehelp wantedremote protocol

仓库指标

星标
 (16,744 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We currently implement total_changes() incorrectly for Hrana client-side protocol because we accumulate the changes per stream, but should do it per connection. I merged the incorrect solution as an intermediate step to expose the API to users because fixing this is a bit involved. Hrana does pass connection to stream but turns it into something useless because of the generics trickery there.

贡献者指南