tursodatabase/libsql

Auto generate bindings when `libsql-sqlite3` is changed

Open

#1,039 创建于 2024年2月16日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C (16,744 star) (490 fork)batch import
good first issue

描述

Whenever there is a change in libsql-sqlite3, we need to generate the sqlite header files and bindings. These commands to be run:

# this updates libsql-ffi and also libsql-sys
cargo xtask build-bundled 
# this updates bindings required for sqlite3-mc
cargo build --features multiple-ciphers

This is a manual step and easy to miss. It happened in #1027 which was fixed later by #1037

We should automate this, as part of the build process. We should also move multiple-ciphers build within build-bundled, so that there is only one command to run

贡献者指南

技术栈
rustcshell
领域
build systemdevopstooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rustcargo build systemC bindingsxtask
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the current build process in the xtask directory, specifically the build bundled command. Understand how libsql sqlite3 changes are detected (e.g., file modification timestamps). Consider integrating the multiple ciphers build into the same command. Look at PRs #1027 and #1037 for context on the manual step that was missed. Propose a solution that runs both commands automatically when libsql sqlite3 source files change.