trixi-framework/Trixi.jl

Checklist to update elixirs to use a better default wave speed for Local Lax-Friedrichs

Open

#2,464 创建于 2025年7月3日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)Julia (686 star) (153 fork)batch import
good first issuepossible student projecttesting

描述

The PR https://github.com/trixi-framework/Trixi.jl/pull/2458/files swaps out Trixi.jl's old wave-speed estimate for a better wave-speed estimate. However, because this would break a lot of CI, #2458 retains the old "naive" wave-speed estimate in elixirs.

This issue is intended to track which CI tests are currently being or have been updated.

  • dgmulti_1d
  • dgmulti_2d
  • dgmulti_3d
  • p4est_2d_dgsem
  • p4est_3d_dgsem
  • paper_self_gravitating_gas_dynamics
  • special_elixirs
  • structured_1d_dgsem
  • structured_2d_dgsem
  • structured_3d_dgsem
  • t8code_2d_dgsem
  • t8code_3d_dgsem
  • tree_1d_dgsem
  • tree_2d_dgsem
  • tree_3d_dgsem
  • unstructured_2d_dgsem
  • unstructured_2d_fdsbp
  • miscellaneous items in test (see #2458)

贡献者指南

技术栈
无
领域
testing
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Trixi.jl test suiteUnderstanding of wave speed estimates
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review PR #2458 to understand the new wave speed estimate and the corresponding changes. Then, for each elixir listed in the checklist, locate the test file and replace the old estimate with the new one. Run the test to ensure it passes. The changes are localized and repetitive.