trinodb/trino

Improve error message when creating tables or adding columns using row type without field names in Delta

Open

#17,549 创建于 2023年5月18日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Java (9,113 star) (2,678 fork)batch import
delta-lakegood first issue

描述

trino:tpch> create table test as select row(123) as c1;
java.lang.NullPointerException: null value in entry: name=null
	at com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:33)
	at com.google.common.collect.ImmutableMapEntry.<init>(ImmutableMapEntry.java:54)
	at com.google.common.collect.ImmutableMap.entryOf(ImmutableMap.java:339)
	at com.google.common.collect.ImmutableMap$Builder.put(ImmutableMap.java:449)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructField(DeltaLakeSchemaSupport.java:188)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.lambda$serializeStructType$5(DeltaLakeSchemaSupport.java:251)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.AbstractList$RandomAccessSpliterator.forEachRemaining(AbstractList.java:720)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructType(DeltaLakeSchemaSupport.java:251)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeColumnType(DeltaLakeSchemaSupport.java:212)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructField(DeltaLakeSchemaSupport.java:189)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.lambda$serializeStructType$2(DeltaLakeSchemaSupport.java:171)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.Collections$2.tryAdvance(Collections.java:4853)
	at java.base/java.util.Collections$2.forEachRemaining(Collections.java:4861)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructType(DeltaLakeSchemaSupport.java:178)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeSchemaAsJson(DeltaLakeSchemaSupport.java:151)
	at io.trino.plugin.deltalake.DeltaLakePageSinkProvider.createPageSink(DeltaLakePageSinkProvider.java:103)
	at io.trino.plugin.base.classloader.ClassLoaderSafeConnectorPageSinkProvider.createPageSink(ClassLoaderSafeConnectorPageSinkProvider.java:49)
	at io.trino.split.PageSinkManager.createPageSink(PageSinkManager.java:49)
	at io.trino.operator.TableWriterOperator$TableWriterOperatorFactory.createPageSink(TableWriterOperator.java:123)
	at io.trino.operator.TableWriterOperator$TableWriterOperatorFactory.createOperator(TableWriterOperator.java:117)
	at io.trino.operator.DriverFactory.createDriver(DriverFactory.java:106)
	at io.trino.execution.SqlTaskExecution$DriverSplitRunnerFactory.createDriver(SqlTaskExecution.java:666)
	at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:877)
	at io.trino.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:187)
	at io.trino.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:561)
	at io.trino.$gen.Trino_testversion____20230518_052710_1.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

trino:tpch> create table test as select row(123) as c1;
Query 20230518_052801_00031_u2ykj failed: null value in entry: name=null
java.lang.NullPointerException: null value in entry: name=null
	at com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:33)
	at com.google.common.collect.ImmutableMapEntry.<init>(ImmutableMapEntry.java:54)
	at com.google.common.collect.ImmutableMap.entryOf(ImmutableMap.java:339)
	at com.google.common.collect.ImmutableMap$Builder.put(ImmutableMap.java:449)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructField(DeltaLakeSchemaSupport.java:188)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.lambda$serializeStructType$5(DeltaLakeSchemaSupport.java:251)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.AbstractList$RandomAccessSpliterator.forEachRemaining(AbstractList.java:720)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructType(DeltaLakeSchemaSupport.java:251)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeColumnType(DeltaLakeSchemaSupport.java:212)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructField(DeltaLakeSchemaSupport.java:189)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.lambda$serializeStructType$2(DeltaLakeSchemaSupport.java:171)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.Collections$2.tryAdvance(Collections.java:4853)
	at java.base/java.util.Collections$2.forEachRemaining(Collections.java:4861)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructType(DeltaLakeSchemaSupport.java:178)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeSchemaAsJson(DeltaLakeSchemaSupport.java:151)
	at io.trino.plugin.deltalake.DeltaLakePageSinkProvider.createPageSink(DeltaLakePageSinkProvider.java:103)
	at io.trino.plugin.base.classloader.ClassLoaderSafeConnectorPageSinkProvider.createPageSink(ClassLoaderSafeConnectorPageSinkProvider.java:49)
	at io.trino.split.PageSinkManager.createPageSink(PageSinkManager.java:49)
	at io.trino.operator.TableWriterOperator$TableWriterOperatorFactory.createPageSink(TableWriterOperator.java:123)
	at io.trino.operator.TableWriterOperator$TableWriterOperatorFactory.createOperator(TableWriterOperator.java:117)
	at io.trino.operator.DriverFactory.createDriver(DriverFactory.java:106)
	at io.trino.execution.SqlTaskExecution$DriverSplitRunnerFactory.createDriver(SqlTaskExecution.java:666)
	at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:877)
	at io.trino.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:187)
	at io.trino.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:561)
	at io.trino.$gen.Trino_testversion____20230518_052710_1.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

trino:tpch> alter table test add column c3 row(int);
Query 20230518_053744_00027_6d3qe failed: Unable to add 'c3' column for: tpch.test
io.trino.spi.TrinoException: Unable to add 'c3' column for: tpch.test
	at io.trino.plugin.deltalake.DeltaLakeMetadata.addColumn(DeltaLakeMetadata.java:1260)
	at io.trino.plugin.base.classloader.ClassLoaderSafeConnectorMetadata.addColumn(ClassLoaderSafeConnectorMetadata.java:336)
	at io.trino.tracing.TracingConnectorMetadata.addColumn(TracingConnectorMetadata.java:442)
	at io.trino.metadata.MetadataManager.addColumn(MetadataManager.java:767)
	at io.trino.tracing.TracingMetadata.addColumn(TracingMetadata.java:449)
	at io.trino.execution.AddColumnTask.execute(AddColumnTask.java:137)
	at io.trino.execution.AddColumnTask.execute(AddColumnTask.java:54)
	at io.trino.execution.DataDefinitionExecution.start(DataDefinitionExecution.java:146)
	at io.trino.execution.SqlQueryManager.createQuery(SqlQueryManager.java:257)
	at io.trino.dispatcher.LocalDispatchQuery.startExecution(LocalDispatchQuery.java:145)
	at io.trino.dispatcher.LocalDispatchQuery.lambda$waitForMinimumWorkers$2(LocalDispatchQuery.java:129)
	at io.airlift.concurrent.MoreFutures.lambda$addSuccessCallback$12(MoreFutures.java:569)
	at io.airlift.concurrent.MoreFutures$3.onSuccess(MoreFutures.java:544)
	at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1138)
	at io.trino.$gen.Trino_testversion____20230518_053713_75.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.NullPointerException: null value in entry: name=null
	at com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:33)
	at com.google.common.collect.ImmutableMapEntry.<init>(ImmutableMapEntry.java:54)
	at com.google.common.collect.ImmutableMap.entryOf(ImmutableMap.java:339)
	at com.google.common.collect.ImmutableMap$Builder.put(ImmutableMap.java:449)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructField(DeltaLakeSchemaSupport.java:188)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.lambda$serializeStructType$5(DeltaLakeSchemaSupport.java:251)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.AbstractList$RandomAccessSpliterator.forEachRemaining(AbstractList.java:720)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructType(DeltaLakeSchemaSupport.java:251)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeColumnType(DeltaLakeSchemaSupport.java:212)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructField(DeltaLakeSchemaSupport.java:189)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.lambda$serializeStructType$2(DeltaLakeSchemaSupport.java:171)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeStructType(DeltaLakeSchemaSupport.java:178)
	at io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport.serializeSchemaAsJson(DeltaLakeSchemaSupport.java:151)
	at io.trino.plugin.deltalake.DeltaLakeMetadata.appendTableEntries(DeltaLakeMetadata.java:1283)
	at io.trino.plugin.deltalake.DeltaLakeMetadata.addColumn(DeltaLakeMetadata.java:1243)
	... 17 more

贡献者指南

技术栈
java
领域
backenddatabase
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic knowledge of Javafamiliarity with Trino Delta Lake connector
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the stack trace in DeltaLakeSchemaSupport.java, specifically the serializeStructField method at line 188. The issue occurs when a row type has no field names (e.g., row(123) or row(int)). The fix should add a null check for the field name and throw a clear exception message indicating that row types require named fields. Also check the addColumn path in DeltaLakeMetadata.java to ensure consistent error handling. No existing PRs or assignees, so this is available for contribution.