tmspzz/Rome

Reduce code duplication in some function

Open

#51 创建于 2017年3月24日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Haskell (771 star) (54 fork)batch import
help wantedready-to-implement

描述

Enhancement Suggestion

Reduce code duplication in some function.

Steps which explain the enhancement

Example of function which could use some slimming down

Current and suggested behavior

Currently there are tiny differences which lead to a ton of duplication. A more careful design can reduce code duplication.

Why would the enhancement be useful to most users This enhancement does nothing for the users but a lot for code quality and maintenance

贡献者指南

技术栈
无
领域
build systemdeveloper experience
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Haskell knowledgefamiliarity with Lib.hs
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Examine the two functions in Lib.hs (lines 290 and 325) to identify shared logic and differences. Propose a refactoring that extracts common functionality into a helper function. The issue is from 2017 with no maintainer feedback, so ensure any changes align with the project's coding style. Consider discussing the approach in the issue before implementing.
Reduce code duplication in some function · tmspzz/Rome#51 | Good First Issue