Should not print error if the file attempting to delete does not exist for `bcsymbolmap` · tmspzz/Rome#209

(4 评论) (0 反应) (0 负责人)Haskell (771 star) (54 fork)batch import

enhancementhelp wanted

描述

When doing the first download, it seems like the "Delete of the bcsymbolmap" causes an error to be printed.

Reproduction Steps:

Create a Romefile with Alamofire
Do the build, and upload the files.
Do rome download

** Expected behavior** Will download the needed files and display:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip

Observed behavior:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap

It looks like in the line:

https://github.com/tmspzz/Rome/blob/3279870fcaac111df5f3a9fd03c10a45c063758c/src/Caches/S3/Downloading.hs#L182

It attempts to delete the file that exists. In the case that the file does not exist, it should just ignore it and not print and error.

Rome version: 0.23.1.61 OS and version: macOS Catalina

贡献者指南

技术栈: 无
领域: backendclicloud
议题类型: bug
难度: 2
预计时间: under 1 hour
活动状态: stale
清晰度: clear
前置要求: Haskell basicsRome codebase structure
新手友好度: 60
研究方向: The issue points to src/Caches/S3/Downloading.hs line 182 where a file deletion occurs and prints an error if the file doesn't exist. Start by reading that file to understand the current deletion logic. The fix is to either check if the file exists before deleting using `doesFileExist` or handle the specific error case. Ensure to maintain backward compatibility. After making the change, test with the reproduction steps provided in the issue.