tleunen/react-mdl

Menu items get broken after update

Open

#400 创建于 2016年9月19日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)CSS (1,772 star) (259 fork)batch import
bughelp wanted

描述

I've created component that renders Menu with 3 items ['a', 'b', 'c'] from state. That works fine. Then I update component state items to ['a', 'x', 'y']. Component re-renders menu, but updated items are broken - they does not hide after click.

Please have a look on codepen for that: http://codepen.io/anon/pen/gwwKvk?editors=0011

贡献者指南

技术栈
javascriptreactcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic React
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the Menu component implementation in react mdl to understand how items are rendered and event handlers are attached. The bug likely involves React's key reconciliation or state update not properly reinitializing menu item click handlers. Check the codepen example to reproduce the issue. Focus on the component's shouldComponentUpdate or componentDidUpdate lifecycle methods.