tikv/tikv

Active written leaders is wrong

Open

#8,155 创建于 2020年6月29日

在 GitHub 查看
 (5 评论) (0 反应) (1 负责人)Rust (15,922 star) (2,189 fork)batch import
difficulty/easyhelp wantedpriority/lowseverity/minorsig/rafttype/bug

描述

Bug Report

What version of TiKV are you using?

Master

What did happened?

https://github.com/tikv/tikv/blob/bcea06ca85daab94f47608d7d98976ec086fb24c/components/raftstore/src/store/worker/pd.rs#L607

PD updates the metrics no matter whether there are keys/bytes written or not. So active written leaders graph actually shows all leaders instead.

贡献者指南

技术栈
rust
领域
databaseobservability
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Rust basicsTiKV PD component understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The bug is in components/raftstore/src/store/worker/pd.rs line 607, where PD updates the 'active written leaders' metric regardless of whether keys or bytes were written. To fix, add a condition to only update the metric when writes are non zero. Examine how other similar metrics in the same file or component handle this. Since the issue has an assignee, check if there is any ongoing work. The fix is localized and well defined.