tikv/tikv

Align key memory location

Open

#3,486 创建于 2018年8月20日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Rust (15,922 star) (2,189 fork)batch import
component/performancedifficulty/mediumhelp wanted

描述

Feature Request

After encoding, our keys are 9*N in length (or 9*N+8 if it has timestamp suffix).

when comparing key equality, or decoding key timestamp, we access its last 8*N part, which is not memory aligned in most cases. Make keys ends with a memory aligned location could improve performance.

贡献者指南

技术栈
rust
领域
performance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Rust memory layoutFamiliarity with TikV key encoding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the key encoding functions in the storage module, likely in the `src/storage` or `src/coprocessor` directories. Examine how keys are currently constructed and where alignment is broken. Look for comments or discussions in the issue thread, especially the single comment, for any additional context or suggestions from maintainers. Consider reading related code for key comparison and timestamp decoding to understand the current memory access patterns.