thu-ml/tianshou

Reduce duplication between examples/atari/atari_network and examples/vizdoom/network

Open

#1,092 创建于 2024年4月3日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (7,121 star) (1,072 fork)batch import
good first issuerefactoring

描述

Also names could maybe be improved. Things there are called DQN and so, even though they're just nets, while there's an independent class called DQNPolicy, which has nothing to do with these classes

贡献者指南

技术栈
pythonpytorch
领域
documentation
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with Python and PyTorchUnderstanding of neural network classes in RL
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue asks to reduce duplication between examples/atari/atari network and examples/vizdoom/network. Begin by comparing the two files to identify shared network architectures and common patterns. Look for ways to create a shared utility or base class, and update both files to use it. Additionally, consider renaming classes to align with the existing DQNPolicy class naming conventions. See comments on the issue for any guidance from maintainers.