Review dynflow-sidekiq exec command · theforeman/foremanctl

(2 条评论) (0 个反应) (0 位负责人)Python (38 个派生)auto 404

foremangood first issue

仓库指标

星标: (25 个星标)
PR 合并指标: (PR 指标待抓取)

描述

Based on https://github.com/evgeni/talks/pull/4#discussion_r1932083989 we should review the command:

https://github.com/theforeman/foreman-quadlet/blob/177348fc149e74a4adb6680cb239181f16cf8476/roles/foreman/tasks/main.yaml#L90

This copies the DYNFLOW_SIDEKIQ_SCRIPT (that's also set as an env var) and hardcodes the Rails environment, but do we even need to expose this in the first place? It's based on https://github.com/theforeman/foreman/blob/74ddd8851cebd21c268002e0c82a3619d2a9db66/extras/systemd/dynflow-sidekiq%40.service#L12-L20 but is it better to provide a better /usr/libexec/foreman/sidekiq-selinux wrapper script that has these defaults built in?

贡献者指南

研究方向: 比较 foreman quadlet 中的命令与上游 systemd 服务文件。评估 DYNFLOW SIDEKIQ SCRIPT 环境变量和硬编码的 Rails 环境是否必要。考虑在 foremanctl 中创建一个包含默认值的包装脚本。
技术栈: pythonshell
领域: backenddevops
议题类型: 重构
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: Git
新手友好度: 70