thedevdojo/voyager

BREAD Field labels have wrong for attribute

开放

#4,247 创建于 2019年7月6日

 (3 条评论) (0 个反应) (0 位负责人)PHP (2,652 个派生)batch import
help wanted

仓库指标

星标
 (11,817 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Version information

This is a code issue / error. It is present on the current "master" branch (1.2)

Description

The form label for attribute is not matched with the name field attribute. It is hardcoded: https://github.com/the-control-group/voyager/blob/7835b366babf63940aef18e52615852eb17e2651/resources/views/bread/edit-add.blade.php#L72

This is my suggestion/fix. <label class="control-label" for="{{ $row->field }}">{{ $row->display_name }}</label>

If you prefer a PR just ask.

Expected behavior

Labels should be matched with the corect form field.

贡献者指南