thedevdojo/voyager

Add fit features for images

Open

#3,590 创建于 2018年9月28日

在 GitHub 查看
 (6 评论) (1 反应) (0 负责人)PHP (11,817 star) (2,652 fork)batch import
help wantedtype:enhancement

描述

We've got an option to crop, resize and upsize an image. However, not always it's possible to predict in what orientation the user will upload an image so that rules resize: 300x300 and crop: 300x300 will result in either square image or rectangle because an image is landscape-oriented. Therefore there is a need in fit like in Intervention/Image so that it will be needed size always. Please, consider to add this option to image fields.

贡献者指南

技术栈
phplaravel
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
PHPLaravelImage manipulation concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requests adding a 'fit' feature to image fields, similar to Intervention Image's fit method. Start by examining existing image handling code in Voyager, likely in the BREAD or media manager controllers (e.g., app/Http/Controllers/VoyagerBreadController.php). Review the current resize and crop implementations to understand the pattern. Check the Intervention Image documentation for the fit method. Then propose adding a new option (e.g., 'fit') to the image field configuration and implement it by calling the Intervention fit method with appropriate parameters. Consider backwards compatibility and whether the new option should override or complement resize/crop. The maintainers may prefer a specific implementation approach, so a discussion in the issue would be beneficial before coding.