testcontainers/testcontainers-java

InternalCommandPortListeningCheck always fails for containers built without `/bin/sh`

Open

#3,317 创建于 2020年10月11日

在 GitHub 查看
 (5 评论) (7 反应) (0 负责人)Java (7,535 star) (1,588 fork)batch import
help wantedtype/bug

描述

Relates to #2984

I'm surprised we've not come across this earlier, but the default TCP port listening detector InternalCommandPortListeningCheck does not work for containers that do not have /bin/sh included.

This predominantly affects images built upon scratch.

The workaround/solution is to use a more application specific WaitStrategy - e.g. an HTTP wait strategy.

However the log messages don't make this easy to realise.

Given that we do both the internal and external port checks for a good reason, I don't think we can just rely on the external port check. Still perhaps we can raise a very specific error message if /bin/sh is not available inside the container.

贡献者指南

技术栈
javadocker
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaDockerTestcontainers basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the InternalCommandPortListeningCheck class in the testcontainers java repository. The issue relates to #2984 and describes that the check fails when /bin/sh is not present inside the container. Consider adding a fallback or a more descriptive error message. Look at how the check currently works and propose a modification to detect the absence of /bin/sh and provide a helpful warning or alternative check.