RFC: Renaming localisations

It looks like the way English localisations are handled right now is by using the key if no localisation file is found. There is no en file, only a file for each other language.

The code calls a method like this, with the English language as the key:

https://github.com/tenacityteam/tenacity/blob/faa23d1b2bc4c7bc62c64922a3b7f891756b796d/src/menus/HelpMenus.cpp#L561-L563

Then, that English text is referenced as a key in a localisation file.

https://github.com/tenacityteam/tenacity/blob/faa23d1b2bc4c7bc62c64922a3b7f891756b796d/locale/fr.po#L1186-L1188

Changing the key does change the text in my tests:

So, I think for renaming we have a few options:

1. Rename all these keys

Merging in changes from upstream could be a lot harder due to all the changes.

2. Add an en localisation file

This would require us to make sure to add to this file when new keys get added. (My preferred solution)

3. Adjust the XO() macro to replace the name Audacity with Tenacity

Kind of a sketchy option, but might be the safest for merging in changes from upstream.

---

What do you guys think? Any other ideas?