tektoncd/pipeline

Disallow unknown keys in feature-flags configmap

开放

#6,938 创建于 2023年7月18日

 (3 条评论) (0 个反应) (0 位负责人)Go (1,943 个派生)auto 404
Hacktoberfesthelp wanted

仓库指标

星标
 (9,013 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Currently, we don't perform any validation of the feature flags configmap. https://github.com/tektoncd/pipeline/pull/6935 adds validation for keys representing existing feature flags, but it's still possible to misspell a feature flag or add a flag that's no longer supported, thinking it has an effect (example: https://github.com/tektoncd/pipeline/pull/6937). We should validate that the configmap doesn't contain any unknown keys. We will probably need to fix https://github.com/tektoncd/pipeline/issues/4542 first, otherwise upgrades will cause problems if we remove feature flags.

贡献者指南