tektoncd/pipeline

refactor fatal and error in unit tests

开放

#6,641 创建于 2023年5月9日

 (10 条评论) (0 个反应) (1 位负责人)Go (1,943 个派生)auto 404
good first issuehelp wanted

仓库指标

星标
 (9,013 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We have a mix of t.Fatalf and t.Errorf in our existing unit tests. It's most of the times user's choice to decide which one to implement. There are no specific guidelines as part a tekton pipeline development process.

As part of this issue:

  • Task 1: Define a specific guideline around t.Fatalf and t.Errorf and document them as part of our unit test best practices.

  • Task 2: Revisit our code base to make sure we are aligned and following with the guidelines documented in Task 1.

See relevant comment - https://github.com/tektoncd/pipeline/pull/6596#discussion_r1188598706

贡献者指南