swiftlang/swift

Incorrect fix-it for static member access on instance

Open

#85,157 创建于 2025年10月27日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)Swift (69,989 star) (10,719 fork)batch import
compilerdiagnostics qualityfix-itsgenericsgood first issueopaque parameter typesstatic declarationstype checker

描述

Description

In the following example the compiler offers to replace p with some P, which is obviously not going to work. The same applies to any P.

Reproduction

protocol P {
  static var x: Int {get}
}
func foo(p: some P) -> Int {
  p.x
}

Expected behavior

We should probably make it wrap the base in type(of:) instead.

Environment

Swift version 6.3-dev (1ae8ef0004e7405)

Additional information

No response

贡献者指南

技术栈
swift
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Swift protocols and genericsFamiliarity with compiler fix it mechanism
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue requires modifying the fix it logic in the Swift compiler. When a static member is accessed on an instance of a protocol existential (e.g., `some P`), the current fix it incorrectly suggests replacing the instance with a concrete type. The correct behavior is to wrap the base expression in `type(of:)`. The relevant code is likely in the diagnostics or constraint solver module. Check the issue comments for any additional context or pointers.
Incorrect fix-it for static member access on instance · swiftlang/swift#85157 | Good First Issue