swiftlang/swift

[SR-8147] Fixit corrects .eventTrackingRunLoopMode to .RunLoop.Mode.eventTracking with invalid leading period

Open

#50,679 创建于 2018年6月29日

在 GitHub 查看
 (21 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
bugcompilerdiagnostics qualitygood first issue

描述
Previous ID SR-8147
Radar rdar://problem/41545427
Original Reporter @jckarter
Type Bug

Attachment: Download
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee None
Priority Medium

md5: 8dc18aea989964e226ca7f5bd1d9df9f

Issue Description:

Compiling the following code emits a fixit to change ‘.eventTrackingRunLoopMode’ to ‘.RunLoop.Mode.eventTracking’ with a leading period which does not compile since the type is fully specified already.

import AppKit

func foo(timer: Timer) {
  RunLoop.current.add(timer, forMode: .eventTrackingRunLoopMode)
}

贡献者指南

技术栈
swift
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift languagecompiler diagnostics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Examine the Swift compiler's fix it emission for deprecated enum values. The bug is that a leading period is added incorrectly when the replacement is a fully qualified type. Look in the source files handling fix it generation for deprecated API replacements, likely in the diagnostics or IDE modules. Ensure that the period is only added when the expression is a dot syntax shorthand.