swiftlang/swift

[SR-6736] Enforce 16-bit limit for # of function parameters, # of tuple type element

Open

#49,285 创建于 2018年1月11日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
bugcompilergood first issue

描述
Previous ID SR-6736
Radar None
Original Reporter @DougGregor
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: ea27fac0ee252473c9618a9257498092

Issue Description:

Swift's ABI uses 16 bits to store the number of parameter types in a function type and the number of element types in a tuple type. We should enforce these limits in the parser, so they don't slip through and become crashes at later phases.

贡献者指南

技术栈
swift
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift compiler internalsABI understandingParser design
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Search the Swift compiler's source code, particularly in the parser (lib/Parse) for places where function types and tuple types are constructed. Add checks to ensure the number of parameters or elements does not exceed the 16 bit limit (65535). If the limit is exceeded, emit a diagnostic error. Write corresponding tests to validate the new behavior. Examine existing tests for similar limit enforcement to follow the pattern.