swiftlang/swift

[SR-5058] Redundant Conformance Diagnostic should have an associated fixit

Open

#47,634 创建于 2017年5月31日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
bugcompilerdiagnostics qualitygood first issue

描述
Previous ID SR-5058
Radar rdar://32431756
Original Reporter @CodaFi
Type Bug
Status In Progress
Resolution

Attachment: Download
Votes 1
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee interfere (JIRA)
Priority Medium

md5: 5985872320450fd433971928ef7a5b14

Issue Description:

The redundant conformance diagnostic can point at the protocol that is redundant, but doesn’t actually offer to remove it.

protocol Foo {}
struct Bar {}

extension Bar: Foo {}
extension Bar: Foo {} // redundant conformance of 'Bar' to protocol 'Foo'

贡献者指南

技术栈
swift
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Swift languageSwift compiler basicsDiagnostic fixit API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is to add a fixit for the redundant conformance diagnostic. Look for the diagnostic emission in the Swift compiler source, likely in lib/Sema or lib/AST. The diagnostic message is about redundant conformance, and the fixit should suggest removing the duplicate conformance declaration. Investigate existing fixits in the compiler (e.g., in LLVM's DiagnosticConsumers) to understand the API for adding fixits. The issue is labeled StarterBug and involves a localized change.
[SR-5058] Redundant Conformance Diagnostic should have an associated fixit · swiftlang/swift#47634 | Good First Issue