swiftlang/swift

[SR-4824] Add tests to check Collection constraints are being enforced

Open

#47,401 创建于 2017年5月7日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
buggood first issuestandard library

描述
Previous ID SR-4824
Radar rdar://problem/32134714
Original Reporter @airspeedswift
Type Bug
Votes 0
Component/s Standard Library
Labels Bug, StarterBug
Assignee djwbrown (JIRA)
Priority Medium

md5: 6b6aabc9be01be2d9974ed98c3c057f8

Issue Description:

https://github.com/apple/swift/pull/9379 removed tests confirming collection's associated types conformed to appropriate protocols e.g. MutableCollection.SubSequence: MutableCollection. Now the compiler is enforcing these, so they were just generating warnings.

They should be replaced by tests checking the compiler is enforcing these rules (by trying to create invalid collections and checking the error messages).

贡献者指南

技术栈
swift
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift basicscollection protocols
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Look at the tests removed in PR #9379 to understand what they validated. Then, create new tests that attempt to define invalid collection types and check the compiler's error messages. Use existing test files as a guide for how to structure tests that expect compiler errors.