swiftlang/swift

[SR-3254] Unhelpful diagnostics for compound name reference.

Open

#45,842 创建于 2016年11月22日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
bugcompilerdiagnostics qualityfunction referencesgood first issueswift 6.0type checker

描述
Previous ID SR-3254
Radar None
Original Reporter @rintaro
Type Bug

Swift version 3.0.1 (swift-3.0.1-RELEASE)
Target: x86_64-unknown-linux-gnu
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee None
Priority Medium

md5: fcfded4004226fb4776f82d7b6864fca

relates to:

  • SR-4867 func foo() {}; foo(_:) // Use of unresolved identifier 'foo'

Issue Description:

func foo(x: Int) {}
let f = foo(_:)

emits:

test.swift:2:9: error: use of unresolved identifier 'foo'
let f = foo(_:)
        ^~~~~~~
test.swift:1:6: note: did you mean 'foo'?
func foo(x: Int) {}
     ^

Because foo does exist. It should be something like:

test.swift:2:9: error: use of unresolved name 'foo(_:)'
let f = foo(_:)
        ^~~~~~~
test.swift:1:6: note: did you mean 'foo(x:)'?
func foo(x: Int) {}
     ^

贡献者指南

技术栈
swift
领域
developer experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift language basicsUnderstanding of compiler error messages
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the Swift compiler's diagnostic emission for compound name references. The relevant code is likely in lib/Sema/TypeCheckExpr.cpp or similar files that handle unresolved identifier errors. The goal is to improve the error message from 'use of unresolved identifier' to something like 'use of unresolved name foo( :)' with a suggestion to use 'foo(x:)'. Look at how the compiler tokenizes and prints function signatures. Also review the related issue SR 4867 for additional context on similar diagnostic improvements.