swiftlang/swift

[SR-1807] Sema should catch and warn about self capture in closures

Open

#44,416 创建于 2016年6月17日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
compilergood first issuenew feature

描述
Previous ID SR-1807
Radar rdar://26865978
Original Reporter @CodaFi
Type New Feature
Votes 0
Component/s Compiler
Labels New Feature, StarterBug
Assignee None
Priority Medium

md5: 3ea294e377274fa3d27e3c3b76ff7bbd

Issue Description:

To maintain parity with Objective-C, we should use our ARC analysis pass in Sema to check for the presence of self capture in blocks without weak or @noescape. This should be a very simple warning modeled after the one in /clang/lib/Sema/SemaChecking.cpp void diagnoseRetainCycle().

贡献者指南

技术栈
swiftcpp
领域
tooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++compiler internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requests adding a warning in the Swift compiler's semantic analysis (Sema) to detect self capture in closures without weak or @noescape. The implementation should follow the existing diagnoseRetainCycle() function in clang/lib/Sema/SemaChecking.cpp. Look into the Swift compiler's ARC analysis pass and add a similar check. The warning should be emitted when a closure captures self strongly and the closure escapes.