swiftlang/swift

[SR-1111] Non-optimized builds should avoid redundant thick_to_objc_metatype conversions

开放

#43,724 创建于 2016年3月30日

 (0 条评论) (0 个反应) (0 位负责人)Swift (10,719 个派生)batch import
IRGencompilergood first issueimprovementnon-optimized only

仓库指标

星标
 (69,989 个星标)
PR 合并指标
 (平均合并 8天 17小时) (30 天内合并 510 个 PR)

描述

Previous ID SR-1111
Radar None
Original Reporter @belkadan
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, IRGen, NotOptimizedOnly, StarterBug
Assignee None
Priority Medium

md5: ee5fa37243b2596a51a6125675863696

Issue Description:

In this code:

import Foundation
func test() -> Bool {
  let a = RunLoop.current
  let b = RunLoop.main
  return a === b
}

We're smart enough to avoid emitting two references to the metadata for NSRunLoop, but not smart enough (in -Onone builds) to avoid emitting the conversion to an ObjC Class twice, which involves a branch. We should be able to reuse the value from the first thick_to_objc_metatype conversion.

贡献者指南