swiftlang/swift

[SR-978] Warn on do {} with only one empty catch {} block

Open

#43,590 创建于 2016年3月18日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
compilerdiagnostics qualitydo catchgood first issueimprovementmissing warningstatementsswift 5.9

描述
Previous ID SR-978
Radar None
Original Reporter @jckarter
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, StarterBug
Assignee MultiColourPixel (JIRA)
Priority Medium

md5: d5f41243d2aaf067f1ecd57198c44970

Issue Description:

Eric Knapp caught some sample code in the wild unwisely using an empty catch block to swallow errors:

https://twitter.com/ejknapp/status/710589235464523776

We should warn on this to encourage people to use try! to trap on unexpected errors instead.

贡献者指南

技术栈
swift
领域
developer experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
understanding of Swift syntaxbasic compiler diagnostics knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requests a warning for `do {} catch {}` blocks where the catch block is empty (i.e., only one empty catch block). To implement this, you need to add a diagnostic in the Swift compiler's semantic analysis phase. Look at existing warnings like 'unused variable' or 'redundant pattern' in the Swift compiler source (likely under `lib/Sema/` or `include/swift/AST/Diagnostics*`). The issue has a JIRA reference but no code changes yet. Check the comments for any prior discussion or proposed implementation details. The goal is to emit a warning when a catch clause is empty, encouraging use of `try!` instead.