swiftlang/swift

[SR-341] Make test/SIL/Parser/witness_with_inherited_gp.sil not depend on stdlib and remove XFAIL

Open

#42,963 创建于 2015年12月22日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Swift (69,989 star) (10,719 fork)batch import
bugcompilergood first issuenfc

描述
Previous ID SR-341
Radar None
Original Reporter @gottesmm
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: 8e2872d7bfc9887a64565cb007fd1902

Issue Description:

From Dmitri some months ago:

The test test/SIL/Parser/witness_with_inherited_gp.sil depends on the standard library implementation details (underscored protocols). It should define its own version of all protocols to ensure that it continues to test what was intended.

I'm making changes to these underscored protocols, the test broke, and I don't know how to update it properly.

I disabled the test.

贡献者指南

技术栈
swift
领域
testingbackend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
SIL knowledgeSwift compiler build setupUnderstanding of XFAIL
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue requires modifying test/SIL/Parser/witness with inherited gp.sil to define its own version of the protocols it uses instead of relying on Swift standard library underscored protocols. Currently the test is XFAIL (expected failure) because changes to stdlib broke it. The fix involves replacing dependencies on stdlib protocols with locally defined protocols that replicate the necessary functionality. After implementing the changes, the XFAIL directive should be removed. The test should still verify the intended behavior related to witness tables with inherited generic parameters.