swiftlang/swift

[SR-340] Refactor SILParser::parseSILInstruction

Open

#42,962 创建于 2015年12月22日

在 GitHub 查看
 (7 评论) (0 反应) (1 负责人)Swift (69,989 star) (10,719 fork)batch import
SILParsercompilergood first issuenfc

描述
Previous ID SR-340
Radar None
Original Reporter @gottesmm
Type Bug
Status In Progress
Resolution
Votes 1
Component/s Compiler
Labels Bug, StarterBug
Assignee d066z (JIRA)
Priority Medium

md5: ee6df5ef735c9655c56ca6ce06200e7e

Issue Description:

parseSILInstruction is horrible and makes me cry every time I see it. It is a method that is ~1900 lines with a huge switch in it. We should refactor it into a visitor structure. In fact it is large enough that we should consider moving it into its own file if it is possible.

贡献者指南

技术栈
swift
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
SIL basicsVisitor patternSwift compiler structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the current implementation of parseSILInstruction in the SILParser file (likely in lib/SIL/SILParser.cpp). Understand the huge switch statement and how it dispatches to different SIL instructions. Research existing visitor patterns in the Swift compiler, such as the SILInstructionVisitor. Propose a refactored structure with multiple visitor classes, each handling a subset of instructions, and consider moving the code to a separate file. Review any comments from the assignee for guidance.