swiftlang/swift-package-manager

dynamically generate flag expectations in tests

Open

#5,474 创建于 2022年5月7日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)Swift (10,145 star) (1,462 fork)batch import
enhancementgood first issue

描述

Many of the tests are currently statically generating the flags for expectations in BuildPlanTests.swift based upon #if os which changes behaviour based on the OS rather than the target. This can cause subtle bugs to arise. We should dynamically compute the arguments.

贡献者指南

技术栈
swift
领域
testing
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Swift knowledgeunderstanding of test infrastructure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue describes a need to replace static #if os flag expectations in BuildPlanTests.swift with dynamically computed arguments. Look at the test files in the SwiftPM repository, particularly around BuildPlanTests, and understand how flags are currently generated. The goal is to compute flags based on the target platform rather than the OS. No linked PRs or assignees; the discussion likely clarifies the approach. Investigate the existing test patterns and propose a method to dynamically generate the expected flags.
dynamically generate flag expectations in tests · swiftlang/swift-package-manager#5474 | Good First Issue