swagger-api/swagger-ui

Setting VALIDATOR_URL=null with Docker results in broken link

开放

#5,519 创建于 2019年8月5日

 (2 条评论) (0 个反应) (0 位负责人)JavaScript (8,801 个派生)batch import
Hacktoberfestcat: dockertype: bug

仓库指标

星标
 (25,447 个星标)
PR 合并指标
 (平均合并 20小时 34分钟) (30 天内合并 14 个 PR)

描述

Q&A (please complete the following information)

  • OS: Docker on Windows 10 with Linux containers
  • Browser: Chrome
  • Version: 76
  • Method of installation: Docker
  • Swagger-UI version: v3.23.4
  • Swagger/OpenAPI version: Swagger 2.0

Describe the bug you're encountering

When running the Docker container with -e VALIDATOR_URL=null, the validator badge is not disabled and instead shows up as a broken link. The documentation at https://github.com/swagger-api/swagger-ui/blob/master/docs/usage/configuration.md#network says to use null to disable the validator badge. It appears that an empty string does disable the validator (i.e. -e VALIDATOR_URL=). I'm not sure which behavior was intended, but if an empty string was the intended way to disable the validator, the documentation should probably be more explicit.

To reproduce...

Steps to reproduce the behavior:

  1. Run Docker container with docker run -d -p 80:8080 -e URL=http://mySwaggerSpec -e VALIDATOR_URL=null swaggerapi/swagger-ui
  2. Browse to the local Swagger UI using something other than localhost (e.g. http://myComputerDnsName)
  3. The validator badge displays as a broken image with a broken link

Expected behavior

The validator badge should not show up at all.

贡献者指南