swagger-api/swagger-codegen

Empty response body handling in typescript-angular2

Open

#4,962 创建于 2017年3月7日

在 GitHub 查看
 (24 评论) (4 反应) (0 负责人)HTML (12,701 star) (5,474 fork)batch import
Client: TypeScriptIssue: Bughelp wanted

描述

Description

Empty response 200 OK codes are not handled by auto generated api code.

Swagger-codegen version

2.2.2

Swagger declaration file content or url
Command line used for generation

language: typescript-angular2

Steps to reproduce

Build an api response just give 200 as http code but no response body

Suggest a Fix

Here's the current api.mustache at line 45;

return response.json()

It should be;

return response.json() || {};

贡献者指南

技术栈
typescripthtml
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic TypeScript knowledgeunderstanding of mustache templates
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The fix is in the api.mustache template file for typescript angular2, specifically line 45 where `return response.json()` is called. Change it to `return response.json() || {};` to handle empty 200 response bodies. Ensure the change is tested and doesn't break other scenarios. See the template at https://github.com/swagger api/swagger codegen/blob/master/modules/swagger codegen/src/main/resources/typescript angular2/api.mustache (or similar path).