supasate/connected-react-router

Browser history stack is modified when time travelling

Open

#36 创建于 2017年2月19日

在 GitHub 查看
 (0 评论) (3 反应) (0 负责人)JavaScript (4,741 star) (606 fork)batch import
bughelp wanted

描述

Currently, when we do time travelling, the ConnectedRouter tries to change the URL bar to match the router state in the redux store (which is changed by Redux DevTools) by using history.push (see here).

This method seems to work fine, however, internally, the real browser history stack is modified (new history is pushed on top of the stack). It would be better if we can change the URL by just moving the pointer in the history stack to match time travelling.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ReactReduxbrowser history API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the ConnectedRouter.js file, specifically the code at line 40 where history.push is called during time travel. Consider replacing history.push with history.replace or manipulating the history stack index directly to avoid adding new entries. Review the react router documentation on history objects for alternatives.
Browser history stack is modified when time travelling · supasate/connected-react-router#36 | Good First Issue