styled-components/vscode-styled-components

[Feature Request] - Syntax highlighting for custom tags

Open

#303 创建于 2021年6月3日

在 GitHub 查看
 (3 评论) (10 反应) (0 负责人)JavaScript (893 star) (123 fork)batch import
E-Hardbugenhancementhelp wanted

描述

Basically an extension of this issue: https://github.com/styled-components/vscode-styled-components/issues/224

Apparently the intellisense is with the TS compiler and can be configured there, but the syntax highlighting is handled by this plugin so setting custom tags in tsconfig.json has no effect on the syntax highlighting.

Is there a reason for this? Can we not just add a VS Code setting or whatever that allows you to set custom tags? Seems like a much better way of doing it than hard-coding tag names for every styled-components-style library under the sun (there are so many now!)

贡献者指南

技术栈
typescriptjavascript
领域
developer experiencetooling
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
VS Code extension developmentTextMate grammarsTypeScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Review the existing grammar definition for styled components (likely in a syntaxes/ directory) to understand how tags are currently handled. Investigate how VS Code's contributes.configuration can be used to add a user setting for custom tags. Look at the linked issue #224 for background on why this was not implemented initially. Consider referencing similar extensions that allow user defined tag names.