stride3d/stride

[Animation] Messy curve/animation/evaluator API

Open

#449 创建于 2019年5月18日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C# (6,001 star) (886 fork)batch import
area-Graphicsenhancementgood first issue

描述

Release Type: Github

Version: Latest

Platform(s): Any

Describe the bug The animation/curve API as it is is not very maintainable and quite restrictive, there's no reason now that generics supports unmanaged and interface type constraints to have two implementation of a class differing in only the generic type they chose, ex : AnimationCurveEvaluatorOptimizedVector3Group / AnimationCurveEvaluatorOptimizedVector4Group. We can replace 2/3 of the files within /Animations by implementing and adding an IInterpolation interface on our math types and including it as a constraint on our generics requiring that kind of features.

贡献者指南

技术栈
csharp
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C# genericsinterface constraintsStride animation systemgame engine math types
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the existing animation curve evaluator classes in the Animations directory (e.g., AnimationCurveEvaluatorOptimizedVector3Group.cs, AnimationCurveEvaluatorOptimizedVector4Group.cs) to identify all duplicated implementations. Propose a generic interface IInterpolation<T> for math types (Vector3, Vector4, etc.) and refactor the evaluators to use a single generic class with the IInterpolation constraint. Ensure the solution compiles and passes existing tests.