stretchr/testify

Equal diff prints uints in hex format

Open

#400 创建于 2017年2月14日

在 GitHub 查看
 (5 评论) (13 反应) (0 负责人)Go (25,958 star) (1,704 fork)batch import
assert.EqualValuesenhancementenhancement: output formathelp wantedpkg-assertrevisit

描述

Equal and EqualValues print uints in hex format when showing diff. It would be much more useful to see 1701, instead of 0x6a5.

Error Trace:    equality_test:34
        Error:          Not equal:
                        expected: float64(1700)
                        received: uint(0x6a5)
        Messages:       Expecting prices to be equal

贡献者指南

技术栈
go
领域
testingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go basicsfamiliarity with testify
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Locate the code in testify that prints the diff. Likely in a file like 'equality.go' or similar. Look for the format string that uses '%x' for uints and change it to '%d'. Check if any existing tests need to be updated. Also consider if the same change applies to other numeric types.