stretchr/testify

Should `Equal` pass too when `EqualValues` would pass?

Open

#235 创建于 2015年11月5日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)Go (25,958 star) (1,704 fork)batch import
enhancementhelp wanted

描述

Right now there are some cases where Equals fails where EqualValues passes. e.g: comparing assert.Equal(t, uint32(5), 5)

However, Equal is a broader term and seems to imply that it would include EqualValues.

I want to consider making Equal pass when EqualValues passes too.

Main thing to research is whether there's any case where that behaviour would translate in an Equal assertion passing when it should be failing.

贡献者指南

技术栈
go
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Research the existing implementations of Equal and EqualValues in the testify codebase. Check for any existing tests that fail when types differ. Review the 10 comments for additional context and any consensus on direction. Consider backward compatibility and whether a new function might be safer.