stretchr/testify

Should `Equal` pass too when `EqualValues` would pass?

Open

#235 创建于 2015年11月5日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)Go (1,704 fork)batch import
enhancementhelp wanted

仓库指标

Star
 (25,958 star)
PR 合并指标
 (平均合并 6天 15小时) (30 天内合并 2 个 PR)

描述

Right now there are some cases where Equals fails where EqualValues passes. e.g: comparing assert.Equal(t, uint32(5), 5)

However, Equal is a broader term and seems to imply that it would include EqualValues.

I want to consider making Equal pass when EqualValues passes too.

Main thing to research is whether there's any case where that behaviour would translate in an Equal assertion passing when it should be failing.

贡献者指南